[webkit-reviews] review denied: [Bug 66065] [chromium] Split tiler into main thread / compositor thread versions : [Attachment 104278] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Adrienne Walker
<enne at google.com>'s request for review:
Bug 66065: [chromium] Split tiler into main thread / compositor thread versions
https://bugs.webkit.org/show_bug.cgi?id=66065

Attachment 104278: Patch
https://bugs.webkit.org/attachment.cgi?id=104278&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104278&action=review


>> Source/WebCore/platform/graphics/chromium/cc/CCLayerTilingData.h:68
>> +	    Tile() : m_i(-1), m_j(-1) { }
> 
> yeah this seems like a problem - this map holds a set of RefPtr<Tile>, but
there's no virtual d'tor declared so when a Tile is destroyed through this path
it won't invoke ~UpdatableTile()

Yeah this is definitely a real bug, so R- because of that.  Otherwise I think
this patch looks pretty great.