[webkit-reviews] review granted: [Bug 66052] Add support of setPasswordEchoEnabled and setPasswordEchoDuration for password echo feature : [Attachment 104240] patch 3

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Chang Shu <cshu at webkit.org>'s
request for review:
Bug 66052: Add support of setPasswordEchoEnabled and setPasswordEchoDuration
for password echo feature
https://bugs.webkit.org/show_bug.cgi?id=66052

Attachment 104240: patch 3
https://bugs.webkit.org/attachment.cgi?id=104240&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104240&action=review


> LayoutTests/platform/wk2/Skipped:1854
> +# WebKitTestRunner needs layoutTestController.setPasswordEchoEnabled
> +# WebKitTestRunner needs layoutTestController.setPasswordEchoDuration

s/layoutTestController/internals/, and I don't understand why it doesn't just
work.