[webkit-reviews] review granted: [Bug 66354] Regression: On Lion, redirects lose HTTP authentication headers : [Attachment 104239] Patch v2 - Requested changes + layout tests

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 66354: Regression:	On Lion, redirects lose HTTP authentication headers
https://bugs.webkit.org/show_bug.cgi?id=66354

Attachment 104239: Patch v2 - Requested changes + layout tests
https://bugs.webkit.org/attachment.cgi?id=104239&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104239&action=review


Great tests!

> Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:556
> +		   d->m_initialCredential = credential;
> +		   
> +		   // FIXME: Support Digest authentication, and
Proxy-Authorization.
> +		   applyBasicAuthorizationHeader(request,
d->m_initialCredential);

I think that you wanted to limit this to actual redirect case for now, since
for original request, we have already applied the credentials (but do get a
willSendRequest on at least some platforms, I think).

> Source/WebCore/platform/network/mac/ResourceHandleMac.mm:512
> +		   d->m_initialCredential = credential;
> +		   
> +		   // FIXME: Support Digest authentication, and
Proxy-Authorization.
> +		   applyBasicAuthorizationHeader(request,
d->m_initialCredential);

Ditto.

> LayoutTests/ChangeLog:11
> +	   * fast/loader/stateobjects/state-url-sets-links-visited.html:

This file shouldn't have been changed.

> LayoutTests/fast/loader/stateobjects/state-url-sets-links-visited.html:17
> +	   alert(style1.color);
> +	   alert(style2.color);

Accidental changes here.