[webkit-reviews] review granted: [Bug 66107] JSC verbose debugging output sometimes doesn't work as expected. : [Attachment 103688] the patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 66107: JSC verbose debugging output sometimes doesn't work as expected.
https://bugs.webkit.org/show_bug.cgi?id=66107

Attachment 103688: the patch
https://bugs.webkit.org/attachment.cgi?id=103688&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103688&action=review


> Source/JavaScriptCore/bytecode/CodeBlock.cpp:549
> +		   printf("bad_regexp(%d)\n", re0);

There is something a little odd about making our dumping robust against bad
regexp numbers here, since I don't think we're robust against other forms of
bad bytecode in dumping.  Still, this is debug code, if this is helpful, sure!
why not!