[webkit-reviews] review requested: [Bug 66145] [chromium] Assert that main thread and compositor thread are used safely : [Attachment 104202] Moved isCCThread to CCLayerTreeHostImplProxy::isImplThread

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 17 11:33:44 PDT 2011


Iain Merrick <husky at google.com> has asked  for review:
Bug 66145: [chromium] Assert that main thread and compositor thread are used
safely
https://bugs.webkit.org/show_bug.cgi?id=66145

Attachment 104202: Moved isCCThread to CCLayerTreeHostImplProxy::isImplThread
https://bugs.webkit.org/attachment.cgi?id=104202&action=review

------- Additional Comments from Iain Merrick <husky at google.com>
In offline discussion with Nat we decided that the functions should live in
CCLayerTreeHostImplProxy. Renamed isCCThread to isImplThread for clarity. I'm
still not happy that these are static but maybe that can be fixed once the
threaded and non-threaded versions of CCLayerTreeHostImplProxy are fully sorted
out.

Per James' request we don't do anything fancy in NDEBUG builds.


More information about the webkit-reviews mailing list