[webkit-reviews] review granted: [Bug 66347] Switch html/* to to new layout types : [Attachment 104121] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 17 11:10:09 PDT 2011


Eric Seidel <eric at webkit.org> has granted Emil A Eklund <eae at chromium.org>'s
request for review:
Bug 66347: Switch html/* to to new layout types
https://bugs.webkit.org/show_bug.cgi?id=66347

Attachment 104121: Patch
https://bugs.webkit.org/attachment.cgi?id=104121&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104121&action=review


> Source/WebCore/html/HTMLAreaElement.cpp:78
> -    m_lastSize = IntSize(-1, -1);
> +    m_lastSize = LayoutSize(-1, -1);

I wonder if this -1 -1 size needs to be a constant in this file.

> Source/WebCore/rendering/RenderImage.cpp:443
> +	       if (scaleFactor != 1.0f)
> +		   mapLocation.scale(scaleFactor, scaleFactor);

The if isn't really necessary. :)


More information about the webkit-reviews mailing list