[webkit-reviews] review granted: [Bug 65174] Accessibility stack exhaustion using role attribute : [Attachment 103381] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 65174: Accessibility stack exhaustion using role attribute
https://bugs.webkit.org/show_bug.cgi?id=65174

Attachment 103381: patch
https://bugs.webkit.org/attachment.cgi?id=103381&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103381&action=review


> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2999
> +    AccessibilityObject* parent;
> +    for (parent = parentObject(); parent &&
!parent->accessibilityIsIgnored(); parent = parent->parentObject()) {

I’d suggest defining this inside the for statement.

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:3006
> +	   if (role == ListBoxOptionRole && parentAriaRole == MenuRole)
> +	       return MenuItemRole;
> +	   // An aria "menuitem" may map to MenuButton or MenuItem depending on
its parent.
> +	   else if (role == MenuItemRole && parentAriaRole == GroupRole)

Yes, no need for else.