[webkit-reviews] review granted: [Bug 66025] DFG non-speculative JIT does not inline the double case of ValueAdd : [Attachment 103564] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 17 10:14:42 PDT 2011


Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 66025: DFG non-speculative JIT does not inline the double case of ValueAdd
https://bugs.webkit.org/show_bug.cgi?id=66025

Attachment 103564: the patch
https://bugs.webkit.org/attachment.cgi?id=103564&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
done2 is a kinda weak name.  A full name would be something like
valueAddDidConvertDoubleToInteger? - maybe that's a little long. ;-)  But
something more descriptive than done2 might me nice.  Otherwise looks great,
r+.


More information about the webkit-reviews mailing list