[webkit-reviews] review granted: [Bug 66022] Only set m_fontDirty if TextSizeAdjust is actually changed. : [Attachment 103562] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 17 09:46:22 PDT 2011


Darin Adler <darin at apple.com> has granted Luke Macpherson
<macpherson at chromium.org>'s request for review:
Bug 66022: Only set m_fontDirty if TextSizeAdjust is actually changed.
https://bugs.webkit.org/show_bug.cgi?id=66022

Attachment 103562: Patch
https://bugs.webkit.org/attachment.cgi?id=103562&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Is there some way to test the performance benefit here? Maybe we could do a
performance test that checks that changing the value back and forth and forcing
style recalculation is significantly slower than setting the value to the same
thing over and over again. It would be great to have a test like that!


More information about the webkit-reviews mailing list