[webkit-reviews] review granted: [Bug 64626] An arrow key collapses directionless selection range in the wrong direction in BiDi : [Attachment 101075] fixes the bug

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 64626: An arrow key collapses directionless selection range in the wrong
direction in BiDi
https://bugs.webkit.org/show_bug.cgi?id=64626

Attachment 101075: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=101075&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=101075&action=review


Seems fine.

> Source/WebCore/editing/FrameSelection.cpp:379
> +    int offset = 0;

Seems non-helpful to initialize this to 0.