[webkit-reviews] review granted: [Bug 66373] Links to Trac from TestFailures page don't always show all relevant revisions : [Attachment 104168] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 66373: Links to Trac from TestFailures page don't always show all relevant
revisions
https://bugs.webkit.org/show_bug.cgi?id=66373

Attachment 104168: Patch
https://bugs.webkit.org/attachment.cgi?id=104168&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104168&action=review


r=me

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.j
s:140
> +	   limit: endRevision - startRevision + 2, // For some reason, Trac
requires limit to be 5 in order to display 4 revisions (e.g.).

What's the example? (since you mentioned "(e.g.)"). I would suggest mentioning
the Trac version we are using (0.11.7) in this comment so as to provide a bit
more context on this Trac bug. Even better, if we know the Trac ticket
associated with this issue then we should list it in this comment (*). Do we
know if this bug has been resolved in a newer version of Trac, say Trac 0.12?
We could also file a WebKit bug to track this Trac issue.

(*) <http://trac.edgewall.org/report/>