[webkit-reviews] review requested: [Bug 66230] Also release media resources when media is completely loaded. : [Attachment 104161] Proposed patch 2.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 17 02:38:50 PDT 2011


Hao Zheng <zhenghao at chromium.org> has asked  for review:
Bug 66230: Also release media resources when media is completely loaded.
https://bugs.webkit.org/show_bug.cgi?id=66230

Attachment 104161: Proposed patch 2.
https://bugs.webkit.org/attachment.cgi?id=104161&action=review

------- Additional Comments from Hao Zheng <zhenghao at chromium.org>
Good idea. Actually, I noticed Document::detach() said:

    // Send out documentWillBecomeInactive() notifications to registered
elements,
    // in order to stop media elements
    documentWillBecomeInactive();

But HTMLMediaElement has not overridden related methods. Please help review my
new patch.


More information about the webkit-reviews mailing list