[webkit-reviews] review denied: [Bug 66031] Chromium plumbing for webkitRequestFullScreen : [Attachment 104002] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied James Kozianski
<koz at chromium.org>'s request for review:
Bug 66031: Chromium plumbing for webkitRequestFullScreen
https://bugs.webkit.org/show_bug.cgi?id=66031

Attachment 104002: Patch
https://bugs.webkit.org/attachment.cgi?id=104002&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104002&action=review


By the way, if you think that ForElement is the best suffix, then just pass a
WebElement parameter like the ChromeClient methods do.

> Source/WebKit/chromium/public/WebView.h:367
> +    // Fullscreen
-----------------------------------------------------------

sorry to be a nut about whitespace, but i had intended for there to be two
blank
lines above each section heading.  apparently, a good number of people haven't
been following that convention, but if you scroll up far enough, you'll see
that
convention in place.  sigh :(