[webkit-reviews] review granted: [Bug 66356] Represent RenderStyle::textOverflow property using an enum instead of a bool. : [Attachment 104130] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Luke Macpherson <macpherson at chromium.org>'s request
for review:
Bug 66356: Represent RenderStyle::textOverflow property using an enum instead
of a bool.
https://bugs.webkit.org/show_bug.cgi?id=66356

Attachment 104130: Patch
https://bugs.webkit.org/attachment.cgi?id=104130&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=104130&action=review


It would be nicer if you also changed the one or two places in rendering code
that query this property to use the enum.

> Source/WebCore/rendering/style/RenderStyleConstants.h:437
> +enum TextOverflow { TextOverflowClip = 0, TextOverflowEllipsis };

Why the = 0?