[webkit-reviews] review denied: [Bug 66220] [chromium] Update WebSettings to support per-script font settings : [Attachment 103908] updated patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 16 18:11:11 PDT 2011


Tony Chang <tony at chromium.org> has denied Matt Falkenhagen
<falken at chromium.org>'s request for review:
Bug 66220: [chromium] Update WebSettings to support per-script font settings
https://bugs.webkit.org/show_bug.cgi?id=66220

Attachment 103908: updated patch
https://bugs.webkit.org/attachment.cgi?id=103908&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103908&action=review


> Source/WebKit/chromium/src/WebSettingsImpl.cpp:59
> +    m_settings->setStandardFontFamily((String)font, script);

Doesn't the conversion from WebString to String happen implicitly?  If not, we
should be using static_cast rather than the c-style cast.


More information about the webkit-reviews mailing list