[webkit-reviews] review granted: [Bug 66343] Wire up relative time to garden-o-matic summary view. : [Attachment 104105] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 16 17:16:47 PDT 2011


Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 66343: Wire up relative time to garden-o-matic summary view.
https://bugs.webkit.org/show_bug.cgi?id=66343

Attachment 104105: Patch
https://bugs.webkit.org/attachment.cgi?id=104105&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104105&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/ui/notifications.js:73
> +    get date()

I'd prefer not to use getters and settings, but we can use them if you feel
strongly.  They secretly turn property accesses into function calls that can do
scary things.


More information about the webkit-reviews mailing list