[webkit-reviews] review denied: [Bug 66342] Add basic scripting support to the test movie plug-in : [Attachment 104102] Patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Anders Carlsson <andersca at apple.com>'s
request for review:
Bug 66342: Add basic scripting support to the test movie plug-in
https://bugs.webkit.org/show_bug.cgi?id=66342

Attachment 104102: Patch
https://bugs.webkit.org/attachment.cgi?id=104102&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104102&action=review


Fix the license and add more comment please.

> Examples/NetscapeCoreAnimationMoviePlugin/MovieNPObject.m:57
> +    NPObject npObject;
> +
> +    QTMovie *movie;

Unnecessary newline.

> Examples/NetscapeCoreAnimationMoviePlugin/MovieNPObject.m:77
> +static NPObject *movieNPObjectAllocate(NPP npp, NPClass *theClass)

* on the wrong side.

> Examples/NetscapeCoreAnimationMoviePlugin/MovieNPObject.m:99
> +static bool movieNPObjectHasMethod(NPObject *obj, NPIdentifier name)

* on the wrong side,

> Examples/NetscapeCoreAnimationMoviePlugin/MovieNPObject.m:103
> +    for (int i = 0; i < NUM_METHOD_IDENTIFIERS; i++)
> +	   if (name == methodIdentifiers[i])
> +	       return true;

Needs braces.