[webkit-reviews] review denied: [Bug 66142] [CSSRegions] RenderRegion should not reference a parent RenderFlowThread : [Attachment 104083] Patch V3

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 66142: [CSSRegions] RenderRegion should not reference a parent
RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=66142

Attachment 104083: Patch V3
https://bugs.webkit.org/attachment.cgi?id=104083&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104083&action=review


Fix the one misspelled method name. Sorry I didn't catch it before.

> Source/WebCore/ChangeLog:47
> +	   (WebCore::RenderRegion::dettachRegion):

Typo. Should be detachRegion

> Source/WebCore/rendering/RenderObjectChildList.cpp:106
> +	       toRenderRegion(oldChild)->dettachRegion();

detachRegion

> Source/WebCore/rendering/RenderRegion.cpp:111
> +void RenderRegion::dettachRegion()

detachRegion

> Source/WebCore/rendering/RenderRegion.h:53
> +    void dettachRegion();

detachRegion