[webkit-reviews] review denied: [Bug 53201] Make GraphicsContext3D use DrawingBuffer : [Attachment 104090] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Jeff Timanus
<twiz at chromium.org>'s request for review:
Bug 53201: Make GraphicsContext3D use DrawingBuffer
https://bugs.webkit.org/show_bug.cgi?id=53201

Attachment 104090: Patch
https://bugs.webkit.org/attachment.cgi?id=104090&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104090&action=review


There's lots of code in here behind #if 0.  Is this not quite finished? R-
since this isn't ready to land, but perhaps you were looking for initial
feedback?

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:599
> +#if 0  // TODO:  Why is this code here?
>      if (!m_markedCanvasDirty && !m_layerCleared)
>	   return;
> +#endif

you don't mean to commit this, do you?

> Source/WebCore/platform/graphics/chromium/Canvas2DLayerChromium.cpp:77
> +
> +#if 0
> +    updatePlatformTexture();
> +#endif
> +

is this meant just for testing or something?

> Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.cpp:89
> +#if 0
> +void CanvasLayerChromium::setTextureChanged()
> +{
> +    m_textureChanged = true;
> +}
> +#endif

why the #if 0?

> Source/WebCore/platform/graphics/chromium/CanvasLayerChromium.cpp:110
> +#if 0

huh?