[webkit-reviews] review granted: [Bug 66318] Summary view should not add multiple entries for the same test failure. : [Attachment 104068] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 16 13:47:51 PDT 2011
Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 66318: Summary view should not add multiple entries for the same test
failure.
https://bugs.webkit.org/show_bug.cgi?id=66318
Attachment 104068: Patch
https://bugs.webkit.org/attachment.cgi?id=104068&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104068&action=review
>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/ui/notifications.js:132
> + return !!Array.prototype.filter.call(this._tests.children,
function(child) {
> + return child.equals(failureAnalysis);
> + }).length;
This feels like something to abstract into base, like the any/all functions in
Python.
More information about the webkit-reviews
mailing list