[webkit-reviews] review granted: [Bug 66144] garden-o-matic needs a summary view with actions for each problem. : [Attachment 104064] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 16 13:46:06 PDT 2011


Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 66144: garden-o-matic needs a summary view with actions for each problem.
https://bugs.webkit.org/show_bug.cgi?id=66144

Attachment 104064: Patch
https://bugs.webkit.org/attachment.cgi?id=104064&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104064&action=review


This looks like a great starting point.  There are a bunch if FIXMES, but we
can iterate on those.  :)

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/script
s/ui/notifications_unittests.js:58
> +    equal(suspiciousCommit.innerHTML, '<div class="description"><a
href="">1</a>title author (reviewer)</div><ul class="actions"><li><button>Roll
out</button></li></ul>');

I usually try to formate these strings using + and line breaks to make them
(and diffs) more readable.


More information about the webkit-reviews mailing list