[webkit-reviews] review denied: [Bug 66142] [CSSRegions] RenderRegion should not reference a parent RenderFlowThread : [Attachment 104070] Patch V2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 16 12:44:28 PDT 2011


Dave Hyatt <hyatt at apple.com> has denied Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 66142: [CSSRegions] RenderRegion should not reference a parent
RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=66142

Attachment 104070: Patch V2
https://bugs.webkit.org/attachment.cgi?id=104070&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
You'll need to tweak this after my landing from r93144. You'll want to ditch my
m_hasRenderFlowThreads boolean now that you added the list, and you can
redefine my hasRenderFlowThreads function on RenderView in terms of the list
being non-empty.

You'll also want to add isValid checks to the region walk I do in
repaintIntoRegions.

Sorry for the conflicts. Should be easy to update though.


More information about the webkit-reviews mailing list