[webkit-reviews] review granted: [Bug 66254] [CSSRegions] Make regions repaint properly. : [Attachment 104073] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 66254: [CSSRegions] Make regions repaint properly.
https://bugs.webkit.org/show_bug.cgi?id=66254

Attachment 104073: Patch
https://bugs.webkit.org/attachment.cgi?id=104073&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=104073&action=review


> Source/WebCore/rendering/RenderFlowThread.cpp:305
> +	   // We only have to issue a repaint in this region if the region rect
intersects the repaint rect.
> +	   LayoutRect flippedRegionRect(region->regionRect());
> +	   flipForWritingMode(flippedRegionRect); // Put the region rect into
physical coordinates.

Can we assume that the rect will only intersect some contiguous set of regions?
That might avoid having to iterate through all regions for each repaint, which
is not terribly efficient.

>
LayoutTests/platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected
.txt:1
> +layer at (0,0) size 800x600

Can the tests avoid the use of so much text, to reduce spurious pixel diffs?