[webkit-reviews] review denied: [Bug 66274] "new EventSource()" should throw SYNTAX_ERR when an invalid argument is passed : [Attachment 104011] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 16 11:11:18 PDT 2011
Adam Barth <abarth at webkit.org> has denied review:
Bug 66274: "new EventSource()" should throw SYNTAX_ERR when an invalid argument
is passed
https://bugs.webkit.org/show_bug.cgi?id=66274
Attachment 104011: Patch
https://bugs.webkit.org/attachment.cgi?id=104011&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch does not appear correct, see:
http://www.w3.org/TR/WebIDL/#es-DOMString
In the null-or-undefined case, we hit step 3, which gives use "null" or
"undefined", which is a valid relative URL. Therefore, we shouldn't throw a
SYNTAX_ERROR in that case.
More information about the webkit-reviews
mailing list