[webkit-reviews] review granted: [Bug 66131] Web Inspector: maintain visible view hierarchy and dispatch common view events automatically : [Attachment 104056] patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Andrey Kosyakov
<caseq at chromium.org>'s request for review:
Bug 66131: Web Inspector: maintain visible view hierarchy and dispatch common
view events automatically
https://bugs.webkit.org/show_bug.cgi?id=66131

Attachment 104056: patch
https://bugs.webkit.org/attachment.cgi?id=104056&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=104056&action=review


Looks good. Please provide a couple of tests!

> Source/WebCore/inspector/front-end/ResourcesPanel.js:533
> +	   this.removeChildView(this.visibleView);

Either leave view as is or detach it at all times.

> Source/WebCore/inspector/front-end/SourceFrame.js:81
> +    show: function(parent)

This change does not look consistent. Please leave parentElement.

> Source/WebCore/inspector/front-end/View.js:54
> +	   if (typeof this.onResize === "function")

Just call onResize.

> Source/WebCore/inspector/front-end/View.js:131
> +    addChildView: function(view, parentElement)

parentElement is unused.

> Source/WebCore/inspector/front-end/View.js:133
> +	   if (view._parent === this)

_parentView