[webkit-reviews] review denied: [Bug 65709] Unwarranted DOM Exception when when canvas2D drawImage is called with src rect out of bounds : [Attachment 103965] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 16 07:00:13 PDT 2011


Justin Novosad <junov at chromium.org> has denied Justin Novosad
<junov at chromium.org>'s request for review:
Bug 65709: Unwarranted DOM Exception when when canvas2D drawImage is called
with src rect out of bounds
https://bugs.webkit.org/show_bug.cgi?id=65709

Attachment 103965: Patch
https://bugs.webkit.org/attachment.cgi?id=103965&action=review

------- Additional Comments from Justin Novosad <junov at chromium.org>
Running tests with a debug build revealed an assertion. -> review -

Investigating...

2011-08-15 17:55:41,470 33060 single_test_runner.py:218 DEBUG worker/1
Stacktrace for fast/canvas/drawImage-with-invalid-args.html:
ASSERTION FAILED: CGImageGetHeight(image.get()) == currHeight -
CGRectIntegral(srcRect).origin.y
/b/build/slave/mac_layout/build/src/third_party/WebKit/Source/WebCore/WebCore.g
yp/../platform/graphics/cg/GraphicsContextCG.cpp(197) : void
WebCore::GraphicsContext::drawNativeImage(NativeImagePtr, const
WebCore::FloatSize &, WebCore::ColorSpace, const WebCore::FloatRect &, const
WebCore::FloatRect &, WebCore::CompositeOperator)


More information about the webkit-reviews mailing list