[webkit-reviews] review granted: [Bug 44114] [Qt] Missing spell check support : [Attachment 103995] Added a platform plugin to allow spell and grammar check in QtWebKit.

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 44114: [Qt] Missing spell check support
https://bugs.webkit.org/show_bug.cgi?id=44114

Attachment 103995: Added a platform plugin to allow spell and grammar check in
QtWebKit.
https://bugs.webkit.org/attachment.cgi?id=103995&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103995&action=review


Great.
I will land manually in order to remove the test line from the changelog.

> Source/WebCore/ChangeLog:11
> +	   No new tests because the line rendering code is copied from the
cairo port.
> +

That is not an excuse for not having tests :)
In our case, the problem is we do not have the plugin running on the bot, so we
cannot test this particular change.

> Source/WebKit/qt/WebCoreSupport/TextCheckerClientQt.cpp:46
> +static void convertToVectorList(const QStringList& list, Vector<String>&
vList)
> +{
> +    const int count = list.count();
> +    vList.resize(count);
> +    for (int i = 0; i < count; ++i)
> +	   vList.append(list.at(i));
> +}

Nice!