[webkit-reviews] review denied: [Bug 65511] Web Inspector: autocomplete combobox for CSS style property names/values. : [Attachment 103635] [PATCH] Suggested solution

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 65511: Web Inspector: autocomplete combobox for CSS style property
names/values.
https://bugs.webkit.org/show_bug.cgi?id=65511

Attachment 103635: [PATCH] Suggested solution
https://bugs.webkit.org/attachment.cgi?id=103635&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103635&action=review


> Source/WebCore/inspector/front-end/StylesSidebarPane.js:956
> +	   if (!curSection) {

Looks like too much copypaste.

> Source/WebCore/inspector/front-end/SuggestBox.js:92
> +	   var bodyElement = this.inputElement.ownerDocument.body;

I've seen this in Popover helper. Is there anything to reuse?

> Source/WebCore/inspector/front-end/suggestBox.css:57
> +/* Vertical Scrollbar Styles */

Can we reuse existing ones?