[webkit-reviews] review granted: [Bug 66216] REGRESSION(r70598): [Chromium] Style changes in textInput event can prevent from updating <textarea> value. : [Attachment 103900] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted MORITA Hajime
<morrita at google.com>'s request for review:
Bug 66216: REGRESSION(r70598): [Chromium] Style changes in textInput event can
prevent from updating <textarea> value.
https://bugs.webkit.org/show_bug.cgi?id=66216

Attachment 103900: Patch
https://bugs.webkit.org/attachment.cgi?id=103900&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103900&action=review


> LayoutTests/editing/input/style-change-during-input-expected.txt:5
> +PASS successfullyParsed is true
> +
> +TEST COMPLETE
> +PASS window.target.value is "hello"

The order of these lines will be fixed if you make the following changes

> LayoutTests/editing/input/style-change-during-input.html:26
> +	   layoutTestController.notifyDone();

Call finishJSTest instead here.

> LayoutTests/editing/input/style-change-during-input.html:30
> +successfullyParsed = true;

You should set window.jsTestIsAsync = true instead.

> Source/WebCore/ChangeLog:11
> +	   dirty. But that is problematic since the editing code assumes
> +	   style staying clean during sellchecking phase.

Please elaborate more before you land; e.g. HTMLTextAreaElement's shadow DOM is
re-created, etc...