[webkit-reviews] review canceled: [Bug 66252] garden-o-matic frontend needs model.getCommitDataList function. : [Attachment 103949] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has canceled Dimitri Glazkov
(Google) <dglazkov at chromium.org>'s request for review:
Bug 66252: garden-o-matic frontend needs model.getCommitDataList function.
https://bugs.webkit.org/show_bug.cgi?id=66252

Attachment 103949: Patch
https://bugs.webkit.org/attachment.cgi?id=103949&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103949&action=review


>>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.
js:118
>> +model.getCommitDataList = function(oldestRevision, newestRevision)
> 
> I would have called this commitDataListForRevisionRange to be explicit about
the types, but this is fine too.

I'll rename.

>>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.
js:122
>> +	var index = model.state.recentCommits.indexOf(commitData);
> 
> Is there a reason to use g_commitIndex?  indexOf requires a linear scan over
recentCommits anyway.

You're right -- I'll rework the algorithm.