[webkit-reviews] review denied: [Bug 66127] Construct SerializedScriptValue from Blob : [Attachment 103892] Patch v2

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Yuta Kitamura
<yutak at chromium.org>'s request for review:
Bug 66127: Construct SerializedScriptValue from Blob
https://bugs.webkit.org/show_bug.cgi?id=66127

Attachment 103892: Patch v2
https://bugs.webkit.org/attachment.cgi?id=103892&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103892&action=review


Thanks!

Just a few last comments.

> Source/WebCore/bindings/js/SerializedScriptValue.cpp:279
> +    static bool serialize(const Blob& blob, Vector<uint8_t>& out)

Thanks for all of the information.

This is why I thought blob was being added.

Is there anyway to collapse this with the current serialization for blob rather
than have two places where it is serialized and need to be maintained to do the
same thing?  (Because this seems like a place where things will easily go wrong
in the future.)

> Source/WebCore/bindings/v8/SerializedScriptValue.h:36
> +#include <wtf/Forward.h>

Why is this being added?