[webkit-reviews] review granted: [Bug 66240] It's hard to tell what the actual result of a failed JS test is in TestWebKitAPI's output : [Attachment 103929] Patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 66240: It's hard to tell what the actual result of a failed JS test is in
TestWebKitAPI's output
https://bugs.webkit.org/show_bug.cgi?id=66240

Attachment 103929: Patch
https://bugs.webkit.org/attachment.cgi?id=103929&action=review

------- Additional Comments from David Levin <levin at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103929&action=review


> Tools/TestWebKitAPI/JavaScriptTest.cpp:79
> +    OwnArrayPtr<char> buffer = adoptArrayPtr(new char[bufferSize]);

Interestingly JSStringGetMaximumUTF8CStringSize seems incorrectly used in
WebKit/Tools/DumpRenderTree/LayoutTestController.cpp where it adds +1 to the
output from it but looking at the implementation of that function. the usage
here is correct.