[webkit-reviews] review granted: [Bug 66215] Web Inspector: not all of the properties have valid descriptors on all platforms. Includes PropertyDescriptor protocol documentation fixes. : [Attachment 103897] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 15 02:50:26 PDT 2011
Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 66215: Web Inspector: not all of the properties have valid descriptors on
all platforms. Includes PropertyDescriptor protocol documentation fixes.
https://bugs.webkit.org/show_bug.cgi?id=66215
Attachment 103897: Patch
https://bugs.webkit.org/attachment.cgi?id=103897&action=review
------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103897&action=review
> Source/WebCore/inspector/InjectedScriptSource.js:227
> + descriptors.push({ name: name, value:
object[name], writable: false, configurable: false, enumerable: true});
Can you add a test for this?
More information about the webkit-reviews
mailing list