[webkit-reviews] review requested: [Bug 61016] [WebWorkers][Chromium] Use v8 Isolates for in-process implementation of WebWorkers : [Attachment 103883] This adds an implementation of in-process dedicated workers to chromium port.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 14 15:16:30 PDT 2011


Dmitry Lomov <dslomov at google.com> has asked  for review:
Bug 61016: [WebWorkers][Chromium] Use v8 Isolates for in-process implementation
of WebWorkers
https://bugs.webkit.org/show_bug.cgi?id=61016

Attachment 103883: This adds an implementation of in-process dedicated workers
to chromium port. 
https://bugs.webkit.org/attachment.cgi?id=103883&action=review

------- Additional Comments from Dmitry Lomov <dslomov at google.com>
The crux of the matter is the reimplementation of WebWorkerClientImpl.
WebWorkerClientImpl now 
implements all three of Worker{Loader,Context,Object}Proxies and delegates the
implementation to 
WebKit's standard WorkerMessagingProxy.
For now, we have 3 implementations of workers in chromium WebKit:
	  - In-process dedicated workers (this checkin)
	  - Inter-process shared workers
	  - Inter-process dedicated workers (defunct after this checkin)
This patch extracts some new common interfaces (WebCommonWorkerBase and
WebCommonWorkerClient) for these 
three implementations. 
Removing the remainings of inter-process dedicated workers -related classes is
left for a separate patch 
(it will require coordinated changes on chromuium side).

Chromium trybots are happy.


More information about the webkit-reviews mailing list