[webkit-reviews] review granted: [Bug 66200] Switch results detail view over to new-style object-oriented UI widgets : [Attachment 103870] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 66200: Switch results detail view over to new-style object-oriented UI
widgets
https://bugs.webkit.org/show_bug.cgi?id=66200

Attachment 103870: Patch
https://bugs.webkit.org/attachment.cgi?id=103870&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103870&action=review


Cool! I am happy you like extensible DOM objects :)

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden
-o-matic.html:62
> +<script src="ui/results.js"></script>

I was wondering if we could put scripts in scripts/ directory:
scripts/ui/results.js.

Similarly styles would go to styles/, and images to images/.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/res
ults.js:101
> +	   var self = this;  // I bet dglazkov knows how to avoid this
ickiness.

you can add use Function.bind(this) --> function(...) {  ... }.bind(this) in
decl.