[webkit-reviews] review denied: [Bug 65347] Refactor JS objects to allocate in static create methods rather than constructors : [Attachment 103642] Fixing build errors

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 65347: Refactor JS objects to allocate in static create methods rather than
constructors
https://bugs.webkit.org/show_bug.cgi?id=65347

Attachment 103642: Fixing build errors
https://bugs.webkit.org/attachment.cgi?id=103642&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103642&action=review


The rest of this patch looks good. But let's get rid of that cast.

> Source/WebCore/bindings/js/JSDOMBinding.h:91
> -	   return cacheDOMStructure(globalObject,
WrapperClass::createStructure(exec->globalData(),
WrapperClass::createPrototype(exec, globalObject)), &WrapperClass::s_info);
> +	   return cacheDOMStructure(globalObject,
WrapperClass::createStructure(exec->globalData(),
JSC::JSValue((JSC::JSCell*)WrapperClass::createPrototype(exec, globalObject))),
&WrapperClass::s_info);

Let's find the missing #include that necessitated this cast. I'd rather not add
a cast like this if we don't have to.