[webkit-reviews] review granted: [Bug 66175] Add shell implementation for Web Audio API's MediaElementAudioSourceNode : [Attachment 103836] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 66175: Add shell implementation for Web Audio API's
MediaElementAudioSourceNode
https://bugs.webkit.org/show_bug.cgi?id=66175

Attachment 103836: Patch
https://bugs.webkit.org/attachment.cgi?id=103836&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103836&action=review


Looks good to me. Is the WebKit Mac port compiling in the WebAudio stuff? If
so, the Xcode project should be updated as well.

> Source/WebCore/webaudio/MediaElementAudioSourceNode.h:38
> +    static PassRefPtr<MediaElementAudioSourceNode> create(AudioContext*,
HTMLMediaElement*);

Conceptually is there any layering violation here? I suspect not because the
webaudio/ classes are all accessible from JavaScript, so they are more or less
at parity with other classes in Source/WebCore/html/; but this is the first
reference from the webaudio/ classes to html/ classes.