[webkit-reviews] review denied: [Bug 66166] garden-o-matic's analyzeUnexpectedFailures needs a completion callback. : [Attachment 103814] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 66166: garden-o-matic's analyzeUnexpectedFailures needs a completion
callback.
https://bugs.webkit.org/show_bug.cgi?id=66166

Attachment 103814: Patch
https://bugs.webkit.org/attachment.cgi?id=103814&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103814&action=review


>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.j
s:292
> +	   model.analyzeUnexpectedFailures(showUnexpectedFailure, function() {
> +	       dismissButterbar();
> +	   });

You can just pass dismissButterbar as the completion callback.	You don't need
the thunk.

>
Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.
js:126
> +    var queriesInFlight = Object.keys(unexpectedFailures).length;

please use base.RequestTracker.