[webkit-reviews] review granted: [Bug 66149] Switch RenderMenuList, RenderListBox, and RenderFieldSet to new layout units : [Attachment 103797] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 66149: Switch RenderMenuList, RenderListBox, and RenderFieldSet to new
layout units
https://bugs.webkit.org/show_bug.cgi?id=66149

Attachment 103797: Patch
https://bugs.webkit.org/attachment.cgi?id=103797&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103797&action=review


> Source/WebCore/rendering/RenderListBox.cpp:484
> +    IntPoint currentMousePosition =
roundedIntPoint(frame()->eventHandler()->currentMousePosition());

Sad times.  That we're rounding. :(

> Source/WebCore/rendering/RenderListBox.cpp:526
> +    LayoutUnit offsetX = destination.x() - absPos.x();
> +    LayoutUnit offsetY = destination.y() - absPos.y();

Sounds like a size to me. :(