[webkit-reviews] review granted: [Bug 26211] Cancel in onbeforeunload dialog sometime causes a button to stop working. : [Attachment 103793] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Andy Estes <aestes at apple.com>'s
request for review:
Bug 26211: Cancel in onbeforeunload dialog sometime causes a button to stop
working.
https://bugs.webkit.org/show_bug.cgi?id=26211

Attachment 103793: Patch
https://bugs.webkit.org/attachment.cgi?id=103793&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103793&action=review


I only glanced over the patch, since Jessie had a deeper look already.

> LayoutTests/fast/loader/form-submission-after-beforeunload-cancel.html:22
> +    return "";

It might be slightly less confusing to return an actual string like "Please
don't agree to closing the page to test". In fact, does this test work for
manual testing? It seems like it should.

> Source/WebCore/loader/FrameLoader.cpp:2736
> +    if (!shouldClose)
> +	    m_submittedFormURL = KURL();

Bad indentation here (five spaces).