[webkit-reviews] review granted: [Bug 60260] [Chromium] Implement the embedders for the HTML5 Track List objects : [Attachment 103345] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 12 12:27:27 PDT 2011


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Tommy
Widenflycht <tommyw at google.com>'s request for review:
Bug 60260: [Chromium] Implement the embedders for the HTML5 Track List objects
https://bugs.webkit.org/show_bug.cgi?id=60260

Attachment 103345: Patch
https://bugs.webkit.org/attachment.cgi?id=103345&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
R=me

I still feel a bit uncomfortable with this change since it is adding unused
code.  The big picture isn't at all clear to me.  Perhaps when you add a patch
that makes use of these new classes, things will start to make more sense to
me.  I might end up suggesting a very different approach at that point.


More information about the webkit-reviews mailing list