[webkit-reviews] review granted: [Bug 64249] Implement proper handling of focusin/focusout events in regard to shadow DOM boundaries. : [Attachment 103750] introduce FocusIn/FocusOutEventDispatchMediator

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hayato Ito
<hayato at chromium.org>'s request for review:
Bug 64249: Implement proper handling of focusin/focusout events in regard to
shadow DOM boundaries.
https://bugs.webkit.org/show_bug.cgi?id=64249

Attachment 103750: introduce FocusIn/FocusOutEventDispatchMediator
https://bugs.webkit.org/attachment.cgi?id=103750&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103750&action=review


> Source/WebCore/dom/Event.h:249
> +class FocusInEventDispatchMediator : public EventDispatchMediator {
> +public:
> +    static PassRefPtr<FocusInEventDispatchMediator>
create(PassRefPtr<Event>, PassRefPtr<Node> oldFocusedNode);
> +private:
> +    explicit FocusInEventDispatchMediator(PassRefPtr<Event>,
PassRefPtr<Node> oldFocusedNode);
> +    virtual bool dispatchEvent(EventDispatcher*) const;
> +    RefPtr<Node> m_oldFocusedNode;
> +};
> +
> +class FocusOutEventDispatchMediator : public EventDispatchMediator {
> +public:
> +    static PassRefPtr<FocusOutEventDispatchMediator>
create(PassRefPtr<Event>, PassRefPtr<Node> newFocusedNode);
> +private:
> +    explicit FocusOutEventDispatchMediator(PassRefPtr<Event>,
PassRefPtr<Node> newFocusedNode);
> +    virtual bool dispatchEvent(EventDispatcher*) const;
> +    RefPtr<Node> m_newFocusedNode;
> +};

Should these go into UIEvent.h/cpp?

> Source/WebCore/dom/Node.cpp:2826
> +	   dispatchDOMActivateEvent(detail, event);

Nice!