[webkit-reviews] review denied: [Bug 66132] Chromium: expose MemoryCache::prune and FontCache::purgeInactiveFontData : [Attachment 103761] Fixed style and compilation issues

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 66132: Chromium: expose MemoryCache::prune and
FontCache::purgeInactiveFontData
https://bugs.webkit.org/show_bug.cgi?id=66132

Attachment 103761: Fixed style and compilation issues
https://bugs.webkit.org/attachment.cgi?id=103761&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103761&action=review


> Source/WebKit/chromium/public/WebCache.h:83
> +    // Prune memory cache.

nit: all of the other comments say "resource cache" instead of "memory cache"

I'd probably move this method to be next to "clear", and it would be very
helpful if you could document the difference between clear and prune.  they
sound like synonyms, but they aren't, right?  makes consumers of this API
have to wonder and search .cpp files for the answer :(

> Source/WebKit/chromium/public/WebFontCache.h:51
> +    WEBKIT_EXPORT static void purgeInactiveFontData();

would it make sense to also name this function "prune"?  it seems like
we might want to use consistent jargon.