[webkit-reviews] review granted: [Bug 66013] [chromium] Add WebThread to WebKitClient : [Attachment 103572] Pass tasks not fnptrs.

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Nat Duca
<nduca at chromium.org>'s request for review:
Bug 66013: [chromium] Add WebThread to WebKitClient
https://bugs.webkit.org/show_bug.cgi?id=66013

Attachment 103572: Pass tasks not fnptrs.
https://bugs.webkit.org/attachment.cgi?id=103572&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103572&action=review


> Source/WebKit/chromium/public/WebKitClient.h:182
> +

nit: insert an extra new line here to preserve spacing between sections

> Source/WebKit/chromium/public/WebThread.h:34
> +// Deleting the thread blocks until all pending, non-deferred tasks have
been

nit: deferred -> delayed (to use the same jargon as the method name)

> Source/WebKit/chromium/public/WebThread.h:41
> +	   virtual void performTask() = 0;

maybe: s/performTask/run/ or just "perform" since it would be task->perform()
(the extra "task" in the function name seems a bit redundant)?