[webkit-reviews] review granted: [Bug 66104] DFG JIT speculation failure code sometimes picks the wrong register as a scratch register. : [Attachment 103683] the patch (fix style)
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 11 19:49:38 PDT 2011
Gavin Barraclough <barraclough at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 66104: DFG JIT speculation failure code sometimes picks the wrong register
as a scratch register.
https://bugs.webkit.org/show_bug.cgi?id=66104
Attachment 103683: the patch (fix style)
https://bugs.webkit.org/attachment.cgi?id=103683&action=review
------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=103683&action=review
> Source/JavaScriptCore/dfg/DFGJITCompiler.cpp:643
> + ASSERT((scratchFPR1 == InvalidFPRReg && scratchFPR2 ==
InvalidFPRReg) || (scratchFPR1 != scratchFPR2));
the latter set of parentheses are redundant, but we can remove them later. :-)
More information about the webkit-reviews
mailing list