[webkit-reviews] review denied: [Bug 66030] [Chromium] New windows opened in javascript are named "_blank" : [Attachment 103583] Patch

[bugzilla-daemon at webkit.org]

Nate Chapin <japhet at chromium.org> has denied Shinya Kawanaka
<shinyak at google.com>'s request for review:
Bug 66030: [Chromium] New windows opened in javascript are named "_blank"
https://bugs.webkit.org/show_bug.cgi?id=66030

Attachment 103583: Patch
https://bugs.webkit.org/attachment.cgi?id=103583&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103583&action=review


> Source/WebCore/ChangeLog:12
> +
> +	   No new tests because this bug occurs only in Chromium.
> +

Please include a test if at all possible.  Even port-specific bugs typically
receive a new layout test, since other ports might regress this behavior at
some point :)

> Source/WebCore/loader/FrameLoader.cpp:3265
> +    if (request.frameName() == "_blank")
> +	   requestWithReferrer.setFrameName("");

This code isn't chromium-specific, so it seems odd that we're fixing this bug
here.  How do the other ports avoid reaching this point with frame mame of
"_blank"?  Is this a v8/jsc difference?

It's possible this is the right place to fix the bug, but it would be good to
understand what chromium is doing differently before committing to this
solution.