[webkit-reviews] review denied: [Bug 66094] [chromium] Expose "min/max scroll size", "has horizontal/vertical scrollbar", "number of wheel handlers" to clients : [Attachment 103685] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Nico Weber
<thakis at chromium.org>'s request for review:
Bug 66094: [chromium] Expose "min/max scroll size", "has horizontal/vertical
scrollbar", "number of wheel handlers" to clients
https://bugs.webkit.org/show_bug.cgi?id=66094

Attachment 103685: Patch
https://bugs.webkit.org/attachment.cgi?id=103685&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103685&action=review


> Source/WebKit/chromium/src/ChromeClientImpl.cpp:971
> +void ChromeClientImpl::numWheelEventHandlersChanged(unsigned
numWheelHandlers)

we don't abbreviate - this should be 'numberOfWheelHandlers'

> Source/WebKit/chromium/src/ChromeClientImpl.h:202
> +    virtual void numWheelEventHandlersChanged(unsigned);

this function seems badly named, shouldn't it be
'numberOfWheelHandlersChanged'?