[webkit-reviews] review granted: [Bug 66037] Pass additional details to client in didCreateIsolatedContext : [Attachment 103588] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Aaron Boodman
<aa at chromium.org>'s request for review:
Bug 66037: Pass additional details to client in didCreateIsolatedContext
https://bugs.webkit.org/show_bug.cgi?id=66037

Attachment 103588: Patch
https://bugs.webkit.org/attachment.cgi?id=103588&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103588&action=review


> Source/WebKit/chromium/public/WebFrameClient.h:44
> +#include "v8/include/v8.h"

we often just forward declare V8 types.  see WebFrame.h for example.

> Source/WebKit/chromium/public/WebFrameClient.h:312
> +    virtual void didCreateIsolatedScriptContext(WebFrame*, int
isolatedWorldId, v8::Handle<v8::Context>) { }

in WebFrame.h, we refer to isolatedWorldId as "worldID"

I assume both of these integers refer to the same thing, so probably would be
good to use the same exact variable name for these.

> Source/WebKit/chromium/src/FrameLoaderClientImpl.cpp:85
> +#if WEBKIT_USING_V8

though it really doesn't matter that much, you might go with USE(V8) to match
what you do below.  since this file is implementing a WebCore interface, and
the WebCore interface uses USE(V8), perhaps this file should do the same?


There are just nits, so R=me.