[webkit-reviews] review denied: [Bug 66067] Expose pageScaleFactor() to Chromium's WebViewImpl : [Attachment 103637] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Fady Samuel
<fsamuel at chromium.org>'s request for review:
Bug 66067: Expose pageScaleFactor() to Chromium's WebViewImpl
https://bugs.webkit.org/show_bug.cgi?id=66067

Attachment 103637: Patch
https://bugs.webkit.org/attachment.cgi?id=103637&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=103637&action=review


> Source/WebKit/chromium/public/WebView.h:206
> +    virtual double pageScaleFactor() const = 0;

it seems odd that this returns double when scalePage takes a float.  one of
these should change to match the other.  zoom uses double.  maybe page scaling
should use double too?