[webkit-reviews] review denied: [Bug 66016] [Qt] Add test for correct order of loadProgress() and loadFinished() signals : [Attachment 103543] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 11 10:21:13 PDT 2011


Benjamin Poulain <benjamin at webkit.org> has denied Caio Marcelo de Oliveira
Filho <cmarcelo at webkit.org>'s request for review:
Bug 66016: [Qt] Add test for correct order of loadProgress() and loadFinished()
signals
https://bugs.webkit.org/show_bug.cgi?id=66016

Attachment 103543: Patch
https://bugs.webkit.org/attachment.cgi?id=103543&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
For the sake of code coverage, could you ensure loadStarted() is also send
before loadProgress()?

+page.mainFrame()->load(QUrl("data:text/html,This is first page")); 
This is a special case. I would like another load() with a local URL.


More information about the webkit-reviews mailing list